From: Ted Zlatanov <tzz@lifelogs.com>
Date: Tue, 05 Feb 2013 21:00:53 GMT
Subject: Re: [PATCH] Add contrib/credentials/netrc with GPG support, try #2
Message-ID: <87y5f2pjay.fsf@lifelogs.com>
In-Reply-To: <7vd2wese6z.fsf@alter.siamese.dyndns.org>

On Tue, 05 Feb 2013 12:23:00 -0800 Junio C Hamano <gitster@pobox.com> wrote: 

JCH> Ted Zlatanov <tzz@lifelogs.com> writes:
JCH> You still need to parse a file that has a "default" entry correctly;
JCH> otherwise the users won't be able to share existing .netrc files
JCH> with other applications e.g. ftp, which is the whole point of this
JCH> series.  Not using values from the "default" entry is probably fine,
JCH> though.
>> 
>> OK; done in PATCHv4.

JCH> Hmph.

JCH> Didn't you remove that from your version of net_netrc_loader when
JCH> you borrowed the bulk of the code from Net::Netrc::_readrc?  I see
JCH> "default" token handled at the beginning of "TOKEN: while (@tok)"
JCH> loop in the original but not in your version I see in v4.

Damn, I accidentally moved that check to /dev/null.  OK, I added it in
PATCHv5.  Thanks for catching that.

Ted