From: Thomas Rast <tr@thomasrast.ch>
Date: Fri, 08 Aug 2014 19:09:44 GMT
Subject: Re: [PATCH v2 04/23] rebase -i: hide interactive command messages in verbose mode
Message-ID: <87y4uyajd3.fsf@thomasrast.ch>
In-Reply-To: <6d4f66b21315661e4f267f59341ebb798232a381.1407368621.git.bafain@gmail.com>

Fabian Ruch <bafain@gmail.com> writes:

> @@ -923,6 +923,8 @@ EOF
>  	;;
>  esac
>  
> +mkdir -p "$state_dir" || die "Could not create temporary $state_dir"
> +
>  git var GIT_COMMITTER_IDENT >/dev/null ||
>  	die "You need to set your committer info first"
>  
> @@ -938,7 +940,6 @@ then
>  fi
>  
>  orig_head=$(git rev-parse --verify HEAD) || die "No HEAD?"
> -mkdir -p "$state_dir" || die "Could not create temporary $state_dir"
>  
>  : > "$state_dir"/interactive || die "Could not mark as interactive"
>  write_basic_state

Why this change?  I can't figure out how it relates to the output
change.

> @@ -873,9 +873,8 @@ test_expect_success 'running "git rebase -i --exec git show HEAD"' '
>  	(
>  		FAKE_LINES="1 exec_git_show_HEAD 2 exec_git_show_HEAD" &&
>  		export FAKE_LINES &&
> -		git rebase -i HEAD~2 >expect
> +		git rebase -i HEAD~2 >expected
>  	) &&
> -	sed -e "1,9d" expect >expected &&
>  	test_cmp expected actual
>  '

Getting rid of these magic removals is a very nice change, thank you.

-- 
Thomas Rast
tr@thomasrast.ch