From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 27 Jul 2021 07:56:38 GMT
Subject: Re: [PATCH v2 1/3] send-pack: fix push.negotiate with remote helper
Message-ID: <87y29sqjd1.fsf@evledraar.gmail.com>
In-Reply-To: <af40bee611d4dbbd9bb5f1466bec0be118b74165.1626370766.git.jonathantanmy@google.com>


On Thu, Jul 15 2021, Jonathan Tan wrote:


> +	git init client &&
> +	test_when_finished 'rm -rf client' &&

Nit (don't think this needs a re-roll): Better to do test_when_finished
before whatever creates the thing, in case the command has a bug/errors
out etc. during development. Ditto the below.