From: Giuseppe Scrivano Date: Sat, 26 Sep 2009 18:46:45 GMT Subject: Re: [PATCH] Remove various dead assignments and dead increments found by the clang static analyzer Message-ID: <87ws3lczmy.fsf@master.homenet> In-Reply-To: Hello, Sverre Rabbelier writes: > Then it would probably have been better to say so by at least marking > your patch as RFC and including such a remark in the cover letter, no? > Also, now that this has been pointed out, you shouldn't expect it to > be included until someone either takes your patch and cleans it up (as > in, checks all statements manually), or until you do so yourself. I really had to include a RFC remark. After what Johannes reported, I think there is need only to restore assignments to argc while other ones can be dropped without problems. I'll post a cleaned patch later. Cheers, Giuseppe