From: Firmin Martin <firminmartin24@gmail.com>
Date: Tue, 11 May 2021 00:46:40 GMT
Subject: RE: [PATCH v1 0/8] format-patch: introduce --confirm-overwrite
Message-ID: <87wns6f66n.fsf@Inspiron.i-did-not-set--mail-host-address--so-tickle-me>
In-Reply-To: <60949be8613c1_8c2220882@natae.notmuch>

Hi Felipe,

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Firmin Martin wrote:
>> Currently, git-format-patch, along with the option --cover-letter,
>> unconditionally overwrites a cover letter with the same name (if
>> present). Although this is a desired behaviour for patches which are
>> auto-generated from Git commits log, it might not be the case for a
>> cover letter whose the content is meticulously written manually.
>
> This is one of the reasons I never use git format-patch directly, but I
> use a tool on top: git send-series[1].

This is good to know. As a newcomer to email-based workflow, I ignored
how people use git format-patch/send-mail efficiently.

> It would be nice if git format-patch grabbed the text of the body from
> somewhere,
In v2, I planned to grab the letter body from the cover letter subject
to being overwritten. Maybe if such a letter doesn't exist, we can instead
inherit the content of the cover letter from prior series.

> and even better if git branch learned --edit-cover-letter.
> None of this invalidates the usefulness of your patches, of course.

>
> Cheers.
>
> [1] https://github.com/felipec/git-send-series
>
> -- 
> Felipe Contreras

Thanks for your comment,

Firmin