From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 30 Aug 2021 11:40:53 GMT
Subject: Re: [PATCH/RFC 3/3] ci: run a pedantic build as part of the GitHub workflow
Message-ID: <87wno3xioa.fsf@evledraar.gmail.com>
In-Reply-To: <20210809013833.58110-4-carenas@gmail.com>


On Sun, Aug 08 2021, Carlo Marcelo Arenas Belón wrote:

> -linux-gcc-4.8)
> +linux-gcc-4.8|pedantic)
>  	# Don't run the tests; we only care about whether Git can be
> -	# built with GCC 4.8, as it errors out on some undesired (C99)
> -	# constructs that newer compilers seem to quietly accept.
> +	# built with GCC 4.8 or with pedantic
>  	;;
>  *)
>  	make test

Aside from Junio's suggested squash in <xmqqeeb1dumx.fsf@gitster.g>
downthread, which would obsolete this comment:

I think this would be clearer by not combining these two, i.e. just:

    linux-gcc-4.8)
        # <existing comment about that setup>
        ;;
    pedantic)
        # <A new comment, or not>
        ;;

We'll surely eventually end up with not just one, but N setups that want
to compile-only, so not having to reword one big comment referring to
them all when we do so leads to less churn...