From: Toon Claes <toon@iotcl.com>
Date: Thu, 30 Oct 2025 09:31:17 GMT
Subject: Re: [PATCH 5/8] builtin/pack-objects: simplify logic to find kept or nonlocal objects
Message-ID: <87wm4cu462.fsf@iotcl.com>
In-Reply-To: <20251028-pks-packfiles-store-drop-list-v1-5-1a3b82030a7a@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> +		/*
> +		 * We have already checked `last_found`, so there is no need to
> +		 * re-check here.
> +		 */
> +		if (p == last_found && last_found != (void *)1)
> +			continue;

Unrelated to the (void *)1 check, shouldn't this be in the beginning of
the loop?

-- 
Cheers,
Toon