From: Sergei Organov <osv@javad.com>
Date: Fri, 08 Feb 2008 14:30:02 GMT
Subject: Re: [PATCH 3/4] git.el: Check for existing buffers on revert.
Message-ID: <87ve4zzfkl.fsf@osv.gnss.ru>
In-Reply-To: <87r6fporp3.fsf@wine.dyndns.org>

Alexandre Julliard <julliard@winehq.org> writes:
> Refuse to revert a file if it is modified in an existing buffer but
> not saved.

What's the point? What if I do want to have modified buffer and still
revert the on-disk file? Why git-revert cares to the level of
prohibiting this?

Besides, it's inconsistent with the rest of Emacs, I think, as in
similar situations Emacs usually allows to either save the buffer(s), do
not save the buffer(s) and continue, or abort operation (I suppose using
(save-some-buffers) call, though I didn't check). See, for example, how
(compile) behaves when some of buffers are not saved.

In fact I believe the way PCL-CVS handles this, and that was implemented
in my earlier patch, is superior compared to this patch. An addition of
save-some-buffers call won't hurt either, but IMHO is not very useful in
the specific case of git-revert.

BTW, what definitely lacks (save-some-buffers) call is git-commit, as it
silently commits on-disk state of a file when corresponding buffer is
modified.

> On success, revert the buffers that contains the files that have been
> reverted.

This part is indeed very handy.

-- Sergei Organov.