From: Pat Thoyts Date: Wed, 09 Jan 2013 14:49:06 GMT Subject: Re: Fwd: git-gui / Warning: "No newline at end of file” Message-ID: <87vcb6bee5.fsf@fox.patthoyts.tk> In-Reply-To: <7vzk0qw8ts.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: >Tobias Preuss writes: > >> Hello. I never got a response. Did my email pass the distribution >> list? Best, Tobias > >Pat? > I did have a brief look at this but I don't have a solution at the moment. The "\ No newline at end of file" is emitted by git at we don't appear to handle it well in the lib/diff.tcl apply_range_or_line function. >> ---------- Forwarded message ---------- >> From: Tobias Preuss >> Date: Tue, Nov 13, 2012 at 9:26 PM >> Subject: git-gui / Warning: "No newline at end of file” >> To: git >> >> >> Hello. >> I noticed a problem when working with git-gui which might be a bug. >> The issue only affects you when you are visually trying to stage >> changes line by line. Here are the steps to reproduce the problem: >> >> 1. Initialize a new repository. >> 2. Create a file with three lines of content each with the word >> "Hello". Do not put a new line at the end of the file. >> 3. Add and commit the file. >> 4. Edit the same file putting words inbetween the three lines. >> 5. Open git-gui and try to stage the changes line by line. >> >> The editor will append the warning "No newline at end of file” to the >> end of the diff. When you are trying to stage a line an error occurs. >> The problem is also illustrated in a question on Stackoverflow [1]. >> >> Please let me know if you need more information or if I should send >> this problem to some other mailing list. >> Thank you, Tobias >> >> ____________ >> [1] http://stackoverflow.com/questions/13223868/how-to-stage-line-by-line-in-git-gui-although-no-newline-at-end-of-file-warnin > -- Pat Thoyts http://www.patthoyts.tk/ PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD