From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 30 Jul 2018 15:06:20 GMT
Subject: Re: [PATCH v3 07/10] fetch: implement fetch.fsck.*
Message-ID: <87va8wu5jn.fsf@evledraar.gmail.com>
In-Reply-To: <20180730145851.GA8074@duynguyen.home>


On Mon, Jul 30 2018, Duy Nguyen wrote:

> On Fri, Jul 27, 2018 at 02:37:17PM +0000, Ævar Arnfjörð Bjarmason wrote:
>> diff --git a/Documentation/config.txt b/Documentation/config.txt
>> index 7ff453c53b..8dace49daa 100644
>> --- a/Documentation/config.txt
>> +++ b/Documentation/config.txt
>> @@ -1467,6 +1467,16 @@ fetch.fsckObjects::
>>  	checked. Defaults to false. If not set, the value of
>>  	`transfer.fsckObjects` is used instead.
>>  
>> +fetch.fsck.<msg-id>::
>> +	Acts like `fsck.<msg-id>`, but is used by
>> +	linkgit:git-fetch-pack[1] instead of linkgit:git-fsck[1]. See
>> +	the `fsck.<msg-id>` documentation for details.
>
> Could you squash this patch in? It would let us auto-complete "git
> config fetch.fsck" in bash/tcsh
>
> -- 8< --
> diff --git a/help.c b/help.c
> index 9c0b5a8de9..32fe466dbf 100644
> --- a/help.c
> +++ b/help.c
> @@ -427,6 +427,7 @@ void list_config_help(int for_human)
>  		{ "color.interactive", "<slot>", list_config_color_interactive_slots },
>  		{ "color.status", "<slot>", list_config_color_status_slots },
>  		{ "fsck", "<msg-id>", list_config_fsck_msg_ids },
> +		{ "fetch.fsck", "<msg-id>", list_config_fsck_msg_ids },
>  		{ "receive.fsck", "<msg-id>", list_config_fsck_msg_ids },
>  		{ NULL, NULL, NULL }
>  	};
> -- 8< --

Thanks! I missed that. Willdo.