From: Hans Jerry Illikainen Date: Fri, 22 Nov 2019 20:23:09 GMT Subject: Re: [PATCH 1/1] gpg-interface: limit search for primary key fingerprint Message-ID: <87v9rby82a.hji@dyntopia.com> In-Reply-To: On Fri, Nov 22 2019, Junio C Hamano wrote: > Wouldn't some of the fields this helper works on be of type "char *"? Wow, that's embarrassing. I completely messed that one up after a looong day. Gah! Fixed and re-built with DEVELOPER=1 and re-ran the test suite for both commits in an attempt to avoid further fuckups. I also fixed the criticism on 2/2 (even though you mentioned that there's no need for that) and sent it as v4 because I'm not sure what the right approach is for changing only 1/2. For future reference; how does the project prefer fixups for a single commit on a multi-patch submission? -- hji