From: Takashi Iwai <tiwai@suse.de>
Date: Thu, 17 Jul 2025 07:03:50 GMT
Subject: Re: [PATCH v3 0/2] git-gui: Add support of SHA256 repo
Message-ID: <87v7nr9u3t.wl-tiwai@suse.de>
In-Reply-To: <2a7f20ef-ad7b-47b5-9c3a-71fbdd11e756@kdbg.org>

On Wed, 16 Jul 2025 19:38:34 +0200,
Johannes Sixt wrote:
> 
> Am 16.07.25 um 09:32 schrieb Takashi Iwai:
> > Here is the v3 patch for git-gui to support SHA256 repos.
> > I put a preliminary patch to clean up $null_sha1 in addition to the
> > correction / update of v2 patch.
> 
> Thanks, queued.
> 
> I applied the following fixups: an obvious typo-fix in a comment and use
> of our wrapper function `git` instead of plain Tcl `exec git`.
> 
> diff --git a/git-gui.sh b/git-gui.sh
> index c437980927fd..523e4df8069a 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -1298,8 +1298,8 @@ if {[catch {
>  	set picked 1
>  }
>  
> -# Use object format as hash algorightm (either "sha1" or "sha256")
> -set hashalgorithm [exec git rev-parse --show-object-format]
> +# Use object format as hash algorithm (either "sha1" or "sha256")
> +set hashalgorithm [git rev-parse --show-object-format]
>  if {$hashalgorithm eq "sha1"} {
>  	set hashlength 40
>  } elseif {$hashalgorithm eq "sha256"} {

Thanks!


Takashi