From: Toon Claes <toon@iotcl.com>
Date: Thu, 29 Jan 2026 14:59:47 GMT
Subject: Re: [PATCH v5 0/4] Fix git-last-modified(1) bug triggered when passing a tree-ish
Message-ID: <87v7gkqxb0.fsf@iotcl.com>
In-Reply-To: <xmqqjyx2elbs.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Toon Claes <toon@iotcl.com> writes:
>
>> Changes in v5:
>> - Use 'commit' instead of 'revision'.
>> - Small typo fixes.
>> - Link to v4: https://patch.msgid.link/20260123-toon-last-modified-tree-v4-0-86bf97bad4e2@iotcl.com
>
> Looking good.  Queued.  Thanks.

I noticed this causes a failure[1] with Meson on Windows. Better leave
it out for now. One of the failures:

    expecting success of 8020.3 'last-modified recursive': 
    	check_last_modified -r <<-\EOF
    	3 a/b/file
    	2 a/file
    	1 file
    	EOF

    ++ check_last_modified -r
    ++ local indir=
    ++ test 1 '!=' 0
    ++ case "$1" in
    ++ break
    ++ cat
    ++ git last-modified -r
    ++ git name-rev --annotate-stdin --name-only --tags
    ++ tr '\t' ' '
    ++ test_cmp expect actual
    ++ test 2 -ne 2
    ++ eval 'GIT_DIR=/dev/null git diff --no-index --ignore-cr-at-eol --' '"$@"'
    +++ GIT_DIR=/dev/null
    +++ git diff --no-index --ignore-cr-at-eol -- expect actual
    diff --git a/expect b/actual
    index 65ac8be..d17615e 100644
    --- a/expect
    +++ b/actual
    @@ -1,3 +1,3 @@
     3 a/b/file
    -2 a/file
    +t2^0 a/file
     1 file
    error: last command exited with $?=1

[1]: https://gitlab.com/gitlab-org/git/-/jobs/12899403428


-- 
Cheers,
Toon