From: Thomas Rast Date: Sat, 09 Nov 2013 21:03:56 GMT Subject: Re: [PATCH 0/5] fix up 'jk/pack-bitmap' branch Message-ID: <87txflnv7n.fsf@linux-k42r.v.cablecom.net> In-Reply-To: <527E7021.8060204@kdbg.org> Johannes Sixt writes: > Am 09.11.2013 12:35, schrieb Torsten Bögershausen: >> >> If I do like this in compat/bswap.h >> >> # define ntohll(n) (n) >> # define htonll(n) (n) >> (on an Intel processor, little endian) >> >> then t5310 passes, even if the uint64_t words are written >> in little endian to disc instead of big endian. > > Of course. You write little endian and also read back little endian; > that should work just fine, no? > > OTOH, if you write with Intel and read with PPC, then you should observe > misbehavior with the above patch. Maybe you could check in a simple test that the bitmap for a very predictable pack (e.g. only one commit) has a certain content, by checking its hash. That would guard against accidental format changes. -- Thomas Rast tr@thomasrast.ch