From: Andreas Schwab <schwab@linux-m68k.org>
Date: Sat, 08 Jul 2017 11:08:23 GMT
Subject: Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()
Message-ID: <87tw2ngp94.fsf@linux-m68k.org>
In-Reply-To: <d1bb978b-a7df-48a8-15c8-80730c77e11c@web.de>

On Jul 08 2017, René Scharfe <l.s.r@web.de> wrote:

> Avoid running over the end of another -- a C string whose length we
> don't know -- by using strcmp(3) instead of memcmp(3) for comparing it
> with another C string.

That's not a good justification for the change, since memcmp never reads
past the differing characters.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."