From: Thomas Rast <tr@thomasrast.ch>
Date: Fri, 08 Aug 2014 19:10:26 GMT
Subject: Re: [PATCH v2 23/23] rebase -i: enable options --signoff, --reset-author for pick, reword
Message-ID: <87sil6ajbx.fsf@thomasrast.ch>
In-Reply-To: <ed19a079924e11edac0163837500c2e8caa2a555.1407368621.git.bafain@gmail.com>

Fabian Ruch <bafain@gmail.com> writes:

> @@ -634,21 +644,24 @@ do_replay () {
>  		comment_for_reflog pick
>  
>  		mark_action_done
> -		do_pick $sha1 || die_with_patch $sha1 "Could not apply $sha1... $rest"
> +		eval do_pick $opts $sha1 \
> +			|| die_with_patch $sha1 "Could not apply $sha1... $rest"

You had me a little puzzled at the switch to 'eval' here.  That is
necessary to match the quoting added in 20/23, not for any change in
this commit.  This commit is simply the first one to trigger this.
Also, are you sure $sha1 does not require quoting through an eval?


Please add tests to this patch.

-- 
Thomas Rast
tr@thomasrast.ch