From: jidanni@jidanni.org
Date: Tue, 30 Dec 2008 00:02:35 GMT
Subject: git apply didn't catch error? [was Re: [PATCH] Documentation/diff-options.txt: unify options]
Message-ID: <87r63q34ys.fsf_-_@jidanni.org>
In-Reply-To: <7vabafe5ai.fsf@gitster.siamese.dyndns.org>

JCH> $ wget http://article.gmane.org/gmane.comp.version-control.git/104017/raw
JCH> $ git apply raw
JCH> error: diff-options.txt: No such file or directory
JCH> $ echo $?
JCH> 1
$ cd Documentation
$ git apply ../raw
$ echo $?
0
So then one thinks "why of course, the changes we already applied."
However if one makes some sneaky changes:
$ diff ../raw.original raw
46c46
< index 5721548..b05503a 100644
---
> index 6721548..c05503a 100644
70c70
< +-w::
---
> +-w::ZZZZZZZZZZZZZZZZZZ
One gets the same $?=0. git apply should scream instead of silently
returning 0 and doing nothing. git version 1.6.0.6.