From: David A. Greene Date: Tue, 06 Mar 2012 22:54:31 GMT Subject: Re: [PATCH 2/2] Support Out-Of-Tree Valgrind Tests Message-ID: <87r4x5e3x4.fsf@smith.obbligato.org> In-Reply-To: <7vboo9qskb.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: >>> Could it be that the reason for the breakage is because you are >>> setting TEST_DIRECTORY to the directory that contains out-of-tree >>> tests, instead of $GIT_BUILD_DIR/t/ directory? >> >> Well, yes. I thought that's what out-of-tree tests are supposed to do. >> They don't live in $GIT_BUILD_DIR/t/ after all. >> >> Perhaps I've misunderstood how the test system is supposed to work. A >> table as you described in README would be most helpful. I thought >> TEST_DIRECTORY is supposed to point to where the tests to run are >> located. >> >>> Shouldn't TEST_DIRECTORY merely a short-hand for GIT_BUILD_DIR/t? >>> What do you find relative to $TEST_DIRECTORY that cannot be found >>> relative to GIT_BUILD_DIR/t? >> >> If that's what TEST_DIRECTORY is supposed to be, always, then it should >> be stated in the comments and README. I had no idea this was an >> invariant. >> >> Thanks for clarifying! > > Not so fast. The questions in the message you are responding to were > not rhetorical. Ah, ok. I don't think I have the proper guru status to answer them. :) Regardless, it seems we need some documentation on what each of these variables is. -Dave