From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 23 Jan 2018 00:08:30 GMT
Subject: Re: [PATCH] format-patch: set diffstat width to 70 instead of default 80
Message-ID: <87r2qhh1xd.fsf@evledraar.gmail.com>
In-Reply-To: <20180122123154.8301-1-pclouds@gmail.com>


On Mon, Jan 22 2018, Nguyễn Thái Ngọc Duy jotted:

> diff --git a/builtin/log.c b/builtin/log.c
> index 14fdf39165..6be79656c5 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -1061,6 +1061,7 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,
>  
>  	memcpy(&opts, &rev->diffopt, sizeof(opts));
>  	opts.output_format = DIFF_FORMAT_SUMMARY | DIFF_FORMAT_DIFFSTAT;
> +	opts.diffopt.stat_width = 70;
>  
>  	diff_setup_done(&opts);

There's no opts.diffopt. Presumably this should be squashed on top:

    -       opts.diffopt.stat_width = 70;
    +       rev->diffopt.stat_width = 70;