From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 15 Feb 2018 20:42:39 GMT
Subject: Re: [PATCH 8/8] perl: hard-depend on the File::{Temp,Spec} modules
Message-ID: <87r2pmf0hs.fsf@evledraar.gmail.com>
In-Reply-To: <20180214235404.GH136185@aiede.svl.corp.google.com>


On Wed, Feb 14 2018, Jonathan Nieder jotted:

> Ævar Arnfjörð Bjarmason wrote:
>
>> --- a/perl/Git.pm
>> +++ b/perl/Git.pm
>> @@ -1324,8 +1324,9 @@ sub _temp_cache {
>>  }
>>
>>  sub _verify_require {
>> -	eval { require File::Temp; require File::Spec; };
>> -	$@ and throw Error::Simple($@);
>> +	require File::Temp;
>> +	require File::Spec;
>> +	return;
>
> Same question as in the other patches: any reason not to simplify by
> using 'use' at the top of the file instead?

I was just going for the minimal change, but yeah, that makes
sense. Will do that in v2.