From: Toon Claes Date: Thu, 06 Aug 2026 14:26:39 GMT Subject: Re: [PATCH v4 0/6] odb: make creation of object database pluggable Message-ID: <87qzkb495s.fsf@emacs.iotcl.com> In-Reply-To: <20260806-pks-odb-create-on-disk-v4-0-ba8b4fdd2e3c@pks.im> Patrick Steinhardt writes: > Hi, > > when creating a new repository we create a couple of on-disk data > structures for the object database. This includes the "objects/" > directory hierarchy with "objects/info" and "objects/pack", which are > specific to the backend. > > This patch series makes the creation of the on-disk data structures > pluggable. While we continue to always create "objects/" regardless of > the backend (it's required for a repository to be recognized as such), > the other subdirectories are now created by the backend. This will allow > other backends to plug in their own logic. > > The series starts with a small detour into the loose-object map. This > detour is required so that we can defer initialization of the object > database itself to a later point in time. > > The series is based on 9a0c4701dc (The 7th batch, 2026-07-22). > > Changes in v4: > - Drop `APPLY_REPOSITOY_FORMAT_SKIP_ODB_CREATION` in favor of explicit > calls to `odb_new()`. > - Remove a useless call to `xstrdup()`. > - Mark a string as translatable. > - Link to v3: https://patch.msgid.link/20260805-pks-odb-create-on-disk-v3-0-c0ee3ac5141f@pks.im Structurally I'm very happy about this version. Only had some nits about comments and formatting, but overall this version looks good to me. Thanks! -- Cheers, Toon