From: Thomas Rast Date: Mon, 30 Jan 2012 13:19:29 GMT Subject: Re: [PATCH 3/3] completion: remove unused code Message-ID: <87pqe1nx9a.fsf@thomas.inf.ethz.ch> In-Reply-To: Felipe Contreras writes: > On Mon, Jan 30, 2012 at 10:22 AM, Junio C Hamano wrote: >> Thomas Rast wrote: >>>Felipe Contreras writes: >>> >>>> No reason. I hope they read the mailing list, otherwise I'll resend >>>> and CC them. A get_maintainers script, or something like that would >>>> make things easier. >>> >>>I simply use >>> >>>  git shortlog -sn --no-merges v1.7.0.. -- contrib/completion/ >>> >>>(In many parts the revision limiter can be omitted without losing much, >>>but e.g. here this drops Shawn who hasn't worked on it since 2009.) >> >> Or "--since=1.year", which you can keep using forever without adjusting. > > Perhaps something like that can be stored in a script somewhere in > git's codebase so that people can set sendemail.cccmd to that. Umm, that seems rather AI-complete. You should always compile the list by hand. For example, the list in this case started 25 SZEDER Gábor 4 Michael J Gruber 3 Teemu Matilainen 3 Thomas Rast Would you Cc Michael, Teemu and me? Probably not. What if it started 5 SZEDER Gábor 4 Michael J Gruber 3 Teemu Matilainen 3 Thomas Rast Also, something I didn't mention so far was that you may be patching squarely into the code of one contributor, even if he only had a single patch in that area. To catch this, you should blame the code you are fixing (you already checked the message of the commit to verify whether the bug/feature was intentional, right?). On top of that, the patch may have involved a large number of people not listed in the Author field. As a random example, $ git shortlog -sn --no-merges v1.7.0..origin/next -- grep.[ch] builtin/grep.[ch] 15 René Scharfe 9 Junio C Hamano 8 Nguyễn Thái Ngọc Duy 5 Michał Kiedrowicz 4 Johannes Schindelin 3 Jeff King 3 Thomas Rast but if you were to submit a patch that disputes the case made by 53b8d931, you should probably cc René, Peff and me (see the Helped-by lines). Ok, this got rather long-winded. But I think the bottom line is, trying to put this in sendemail.cccmd is trying to script common sense. -- Thomas Rast trast@{inf,student}.ethz.ch