From: Thomas Rast Date: Thu, 31 May 2012 09:33:51 GMT Subject: Re: Bug: rebase when an author uses accents in name on MacOSx Message-ID: <87pq9k66f4.fsf@thomas.inf.ethz.ch> In-Reply-To: <20120531011911.GC5488@sigill.intra.peff.net> Jeff King writes: > On Wed, May 30, 2012 at 04:45:33PM -0700, Junio C Hamano wrote: > >> Lanny Ripple writes: >> >> > lanny;~> echo "Rémi Leblond" | LANG=C LC_ALL=C sed -ne 's/.*/GIT_AUTHOR_NAME='\''&'\''/p' >> > GIT_AUTHOR_NAME='R'émi Leblond >> >> So in C locale where each byte is supposed to be a single character, >> that implementation of "sed" refuses to match a byte with high-bit >> set when given a pattern '.'? >> >> That is a surprising breakage, I would have to say. > > It should not be too surprising, since we discussed it a few months ago: > > http://thread.gmane.org/gmane.comp.version-control.git/192218 > > Thomas provided a gross but workable solution here: > > http://article.gmane.org/gmane.comp.version-control.git/192237 > > and we also talked about eventually having a shell-quoting mechanism for > pretty placeholders. Then the discussion rambled into "this sed is > horribly broken, and the user should get a better sed" territory. Maybe > we need to revisit that decision, since this is now two bug reports. Three actually, also counting Will Palmer (shruggar) who brought this up on #git-devel shortly before the thread above. -- Thomas Rast trast@{inf,student}.ethz.ch