From: Thomas Rast <trast@inf.ethz.ch>
Date: Wed, 29 May 2013 08:21:37 GMT
Subject: Re: [PATCH v2 22/25] string_list_add_refs_by_glob(): add a comment about memory management
Message-ID: <87ppwaurfy.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <1369472904-12875-23-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> Since string_list_add_one_ref() adds refname to the string list, but
> the lifetime of refname is limited, it is important that the
> string_list passed to string_list_add_one_ref() has strdup_strings
> set.  Document this fact.
>
> All current callers do the right thing.
[...]
> +/*
> + * The list argument must have strdup_strings set on it.
> + */
>  void string_list_add_refs_by_glob(struct string_list *list, const char *glob)
>  {
>  	if (has_glob_specials(glob)) {

Maybe add an assert() so that this is bulletproof?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch