From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 04 Oct 2021 14:54:08 GMT
Subject: Re: [PATCH 10/10] built-ins: plug memory leaks with unpack_trees_options_release()
Message-ID: <87pmskn8mc.fsf@evledraar.gmail.com>
In-Reply-To: <CABPp-BFr7R_swdxswmoGRF3=uu0s8HgppfrnFEQ+NvS1oh+_og@mail.gmail.com>


On Mon, Oct 04 2021, Elijah Newren wrote:

> On Sun, Oct 3, 2021 at 5:46 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>>
>> Plug memory leaks in various built-ins that were missing
>> unpack_trees_options_release() calls. In an earlier commit these
>> functions were all made to use the "UNPACK_TREES_OPTIONS_INIT" macro,
>> now let's have the ones that didn't clean up their memory do so.
>
> This commit message doesn't say anything about what was leaking.  You
> should really bring up that it was the dir_clear() you added to
> unpack_trees_options_release() earlier in the series that is important
> here (or at least that's what I presume is the important fix).

*nod*, willdo.

> Looks good to me; thanks for catching and fixing these leaks.