From: Toon Claes Date: Mon, 09 Nov 2026 16:23:44 GMT Subject: Re: What's cooking in git.git (Nov 2026, #03) Message-ID: <87pkwex9bj.fsf@dev.null.iotcl.com.invalid> In-Reply-To: Junio C Hamano writes: > * ps/grep-recurse-submodules-fix (2026-11-03) 3 commits > - builtin/grep: read ".gitmodules" via passed-in repository > - builtin/grep: read sparse directory trees via passed-in repository > - builtin/grep: read submodule trees via their repository > > A regression where 'git grep --recurse-submodules' failed to read > nested trees in a submodule has been fixed by passing the correct > repository context pointer instead of relying on the global > 'the_repository' variable. Additional latent bugs where grep_cache() > and grep_objects() incorrectly referenced the global state have also > been corrected. > > Needs review. > source: <20261103-pks-grep-recurse-submodule-v2-0-b00e3b3dc865@pks.im> My comment on v1 was addressed, and I've got no further comments about v2. Changes are fairly small, and seem not at all controversial to me. -- Laters, Toon