From: Andreas Schwab <schwab@linux-m68k.org>
Date: Sat, 08 Jul 2017 13:38:55 GMT
Subject: Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()
Message-ID: <87o9svgia8.fsf@linux-m68k.org>
In-Reply-To: <e46a7de9-3e0e-4eeb-c9a3-a8b5f22620b4@web.de>

On Jul 08 2017, René Scharfe <l.s.r@web.de> wrote:

> Am 08.07.2017 um 13:08 schrieb Andreas Schwab:
>> On Jul 08 2017, René Scharfe <l.s.r@web.de> wrote:
>>
>>> Avoid running over the end of another -- a C string whose length we
>>> don't know -- by using strcmp(3) instead of memcmp(3) for comparing it
>>> with another C string.
>>
>> That's not a good justification for the change, since memcmp never reads
>> past the differing characters.
>
> Interesting.  Where does that guarantee come from?

Sorry, I misremembered.  It's only memchr that has this restriction.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."