From: Paul Collins <paul@briny.ondioline.org>
Date: Sun, 06 Nov 2005 21:07:45 GMT
Subject: Re: What's in git.git tonight
Message-ID: <87mzkh8oym.fsf@briny.internal.ondioline.org>
In-Reply-To: <7vmzkhy5on.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

> merlyn@stonehenge.com (Randal L. Schwartz) writes:
>
>> And, I've confirmed that this patch does the trick, and will probably
>> defer any other issues with "optional" packages in the future:
>
> Thanks.  Next time around could you sign-off your patch?

A tiny nit:

---

Consistency is the hobgoblin of small minds, and mine is tiny indeed.
Do not search the current directory when including expat.h, since it
is not supplied by git.

Signed-off-by: Paul Collins <paul@briny.ondioline.org>

diff --git a/http-push.c b/http-push.c
index c10067c..89fda42 100644
--- a/http-push.c
+++ b/http-push.c
@@ -7,7 +7,7 @@
 
 #include <curl/curl.h>
 #include <curl/easy.h>
-#include "expat.h"
+#include <expat.h>
 
 static const char http_push_usage[] =
 "git-http-push [--complete] [--force] [--verbose] <url> <ref> [<ref>...]\n";


-- 
Dag vijandelijk luchtschip de huismeester is dood