From: Adrian Ratiu <adrian.ratiu@collabora.com>
Date: Wed, 11 Mar 2026 11:08:42 GMT
Subject: Re: [PATCH 01/10] hook: move unsorted_string_list_remove() to string-list.[ch]
Message-ID: <87ms0eaait.fsf@gentoo.mail-host-address-is-not-set>
In-Reply-To: <abB3V4BcYDgMJo0x@szeder.dev>

On Tue, 10 Mar 2026, SZEDER Gábor <szeder.dev@gmail.com> wrote:
> On Mon, Mar 09, 2026 at 02:54:07AM +0200, Adrian Ratiu wrote:
>> Move the convenience wrapper from hook to string-list since
>> it's a more suitable place. Add a doc comment to the header.
>
> unsorted_string_list_remove() in string-list has a 'free_util'
> parameter that didn't exist in its original version in 'hook.c', but
> it's not mentioned in the commit message.
> Furthermore, none of the function's callsites are adjusted to the new
> parameter, and the build fails with:
>
>   hook.c: In function ‘hook_config_lookup_all’:
>   hook.c:151:33: error: too few arguments to function ‘unsorted_string_list_remove’
>     151 |                                 unsorted_string_list_remove(e->value, hook_name);
>         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>   In file included from hook.h:5,
>                    from hook.c:5:
>   string-list.h:273:6: note: declared here
>     273 | void unsorted_string_list_remove(struct string_list *list, const char *str,
>         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>   hook.c:163:25: error: too few arguments to function ‘unsorted_string_list_remove’
>     163 |                         unsorted_string_list_remove(hooks, hook_name);
>         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>   string-list.h:273:6: note: declared here
>     273 | void unsorted_string_list_remove(struct string_list *list, const char *str,
>         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>   hook.c:180:25: error: too few arguments to function ‘unsorted_string_list_remove’
>     180 |                         unsorted_string_list_remove(&data->disabled_hooks,
>         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>   string-list.h:273:6: note: declared here
>     273 | void unsorted_string_list_remove(struct string_list *list, const char *str,
>         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>   make: *** [Makefile:2917: hook.o] Error 1

Excellent catch, thanks!

I have been moving a lot of code around for this series and I ended up
updating the call sites in a later commit, causing this breakage.

Will fix in v2 as well as document the introduction of the new parameter
in the commit message.