From: Jim Meyering <jim@meyering.net>
Date: Thu, 10 Jan 2008 18:05:56 GMT
Subject: Re: [PATCH] bundle, fast-import: detect write failure
Message-ID: <87lk6xftdn.fsf@rho.meyering.net>
In-Reply-To: <20080110162526.GB27808@artemis.madism.org>

Pierre Habouzit <madcoder@artemis.madism.org> wrote:
...
>> On the other hand, if that write failure is truly ignorable,
>> a mindless minimalist :-) might argue that it's best just to
>> omit the syscall.
>
>   And leak a file descriptor :)

Not that mindless.
The *write* syscall, not the close.
I would never suggest eliminating the close.