From: Thomas Rast <tr@thomasrast.ch>
Date: Sun, 22 Dec 2013 10:55:36 GMT
Subject: Re: [PATCH] do not pretend sha1write returns errors
Message-ID: <87lhzdqhnb.fsf@thomasrast.ch>
In-Reply-To: <20131221141325.GA23828@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The sha1write function returns an int, but it will always be
> "0". The failure-prone parts of the function happen in the
> "flush" callback, which cannot pass an error back to us. So
> we just end up calling die() during the flush.
>
> Let's just drop the return value altogether, as it only
> confuses callers into thinking that it might be useful.
>
> Only one call site actually checked the return value. We can
> drop that check, since it just led to a die() anyway.
>
> Signed-off-by: Jeff King <peff@peff.net>

Thanks.

> This is kind of a step backwards if we ever wanted to actually make
> sha1write's return code mean anything. But I just don't foresee that
> happening.

Meh.  It hasn't returned a useful value since its introduction in 2005.

-- 
Thomas Rast
tr@thomasrast.ch