From: David Kastrup Date: Thu, 01 May 2014 14:14:21 GMT Subject: Re: [PATCH 6/8] CodingGuidelines: call the conditional statement "if ()", not "if()" Message-ID: <87lhulziv6.fsf@fencepost.gnu.org> In-Reply-To: <1398894312-30763-7-git-send-email-gitster@pobox.com> Junio C Hamano writes: > The point immediately before it is about having SP after the control > keyword. Follow it. > > Signed-off-by: Junio C Hamano > --- > Documentation/CodingGuidelines | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > index 1b0cd2b..21e4272 100644 > --- a/Documentation/CodingGuidelines > +++ b/Documentation/CodingGuidelines > @@ -184,7 +184,7 @@ For C programs: > of "else if" statements, it can make sense to add braces to > single line blocks. > > - - We try to avoid assignments inside if(). > + - We try to avoid assignments inside "if ()" condition. That's not grammatical. -- David Kastrup