From: David Kågedal Date: Mon, 15 Jan 2007 16:53:29 GMT Subject: Re: [PATCH] Reencode committer info to utf-8 before formatting mail header Message-ID: <87k5zo44fq.fsf@morpheus.local> In-Reply-To: <7vd55jrj38.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: >> diff --git a/utf8.h b/utf8.h >> index a07c5a8..eb64d46 100644 >> --- a/utf8.h >> +++ b/utf8.h >> @@ -8,7 +8,7 @@ int is_encoding_utf8(const char *name); >> void print_wrapped_text(const char *text, int indent, int indent2, int len); >> >> #ifndef NO_ICONV >> -char *reencode_string(const char *in, const char *out_encoding, const char *in_encoding); >> +char *reencode_string(const char *in, const char *out_encoding, const char *in_encoding, int *len); >> #else >> #define reencode_string(a,b,c) NULL >> #endif > > This feels fishy... I admit that I didn't test-compile with NO_ICONV. -- David Kågedal