From: Jim Meyering Date: Tue, 19 Aug 2008 18:46:30 GMT Subject: [PATCH] * remote.c (valid_fetch_refspec): remove useless if-before-free test Message-ID: <87k5ecx2pl.fsf@rho.meyering.net> We removed a handful of these useless if-before-free tests several months ago. This change removes a new one that snuck back in. Signed-off-by: Jim Meyering --- There are four in regex.c, too, but that's imported code, so probably not worth modifying in git: compat/regex.c: if (var) free (var) compat/regex.c: if (preg->buffer != NULL) free (preg->buffer) compat/regex.c: if (preg->fastmap != NULL) free (preg->fastmap) compat/regex.c: if (preg->translate != NULL) free (preg->translate) remote.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/remote.c b/remote.c index f61a3ab..105668f 100644 --- a/remote.c +++ b/remote.c @@ -579,8 +579,7 @@ int valid_fetch_refspec(const char *fetch_refspec_str) struct refspec *refspec; refspec = parse_refspec_internal(1, fetch_refspec, 1, 1); - if (refspec) - free(refspec); + free(refspec); return !!refspec; } -- 1.6.0.9.gae2e487