From: Sergey Organov <sorganov@gmail.com>
Date: Mon, 29 Jan 2024 09:35:49 GMT
Subject: Re: what should "git clean -n -f [-d] [-x] <pattern>" do?
Message-ID: <87jzns7a8a.fsf@osv.gnss.ru>
In-Reply-To: <xmqqzfwrjdul.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Sergey Organov <sorganov@gmail.com> writes:
>
>> I'm still arguing in favor of fixing "-n", and I believe a fix is needed
>> independently from decision about "-f -f".
>
> Even though I do not personally like it, I do not think "which
> between do-it (f) and do-not-do-it (n) do you want to use?" is
> broken.  It sometimes irritates me to find "git clean" (without "-f"
> or "-n", and with clean.requireForce not disabled) complain, and I
> personally think "git clean" when clean.requireForce is in effect
> and no "-n" or "-f" were given should pretend as if "-n" were given.

As a note, I'd consider to get rid of 'clean.requireForce' anyway, as
its default value provides safe reasonably behaving environment, and I
fail to see why anybody would need to set it to 'false'.

Thanks,
-- Sergey Organov