From: Adrian Ratiu <adrian.ratiu@collabora.com>
Date: Wed, 11 Mar 2026 11:09:58 GMT
Subject: Re: [PATCH 03/10] hook: rename cb_data_free/alloc -> hook_data_free/alloc
Message-ID: <87jyviaagp.fsf@collabora.com>
In-Reply-To: <abFC3ToqvzCZ25h4@pks.im>

On Wed, 11 Mar 2026, Patrick Steinhardt <ps@pks.im> wrote:
> On Mon, Mar 09, 2026 at 02:54:09AM +0200, Adrian Ratiu wrote:
>> diff --git a/hook.h b/hook.h
>> index e949f5d488..e514c1b45b 100644
>> --- a/hook.h
>> +++ b/hook.h
>> @@ -43,8 +43,8 @@ struct hook {
>>  	void *feed_pipe_cb_data;
>>  };
>>  
>> -typedef void (*cb_data_free_fn)(void *data);
>> -typedef void *(*cb_data_alloc_fn)(void *init_ctx);
>> +typedef void (*hook_data_free_fn)(void *data);
>> +typedef void *(*hook_data_alloc_fn)(void *init_ctx);
>>  
>>  struct run_hooks_opt
>>  {
>
> Ah, this here is also a small style issue that you may want to fix up in
> the preceding patch. For structures, the curly brace goes on the same
> line.

Ack, will fix this in v2 together with the rest of style issues pointed
out. Thanks!