From: Sergey Organov <sorganov@gmail.com>
Date: Sat, 19 Dec 2020 16:23:34 GMT
Subject: Re: [PATCH v2 26/33] diff-merges: let new options enable diff without -p
Message-ID: <87im8xlq7t.fsf@osv.gnss.ru>
In-Reply-To: <5fde01924f744_1de0de208ea@natae.notmuch>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Sergey Organov wrote:
>> The problem is that original name I've used lies to the reader, or, more
>> precisely, tells half-truth. True meaning of the variable is "do run
>> diff for any commit, no matter if it's merge or not". So "need_diff" is
>> already better than "regulars_need_diff".
>> 
>> Maybe "diff_all_commits" will do?
>
> all_need_diff

Fine with me.

Thanks,
-- Sergey