From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 13 Apr 2021 14:23:15 GMT
Subject: Re: [PATCH 1/2] diff tests: remove redundant case statement
Message-ID: <87im4q2rho.fsf@evledraar.gmail.com>
In-Reply-To: <CAHd-oW5nwzg4iiDheMPLe_M19SXO9hPhGeJK8dWfZ-yTKkPVmA@mail.gmail.com>


On Tue, Apr 13 2021, Matheus Tavares Bernardino wrote:

> On Tue, Apr 13, 2021 at 9:31 AM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>>
>> diff --git a/t/t4013-diff-various.sh b/t/t4013-diff-various.sh
>> index 6cca8b84a6b..67f6411aff9 100755
>> --- a/t/t4013-diff-various.sh
>> +++ b/t/t4013-diff-various.sh
>> @@ -220,13 +220,7 @@ do
>>                 then
>>                         process_diffs "$actual" >actual &&
>>                         process_diffs "$expect" >expect &&
>> -                       case $cmd in
>> -                       *format-patch* | *-stat*)
>> -                               test_cmp expect actual;;
>> -                       *)
>> -                               test_cmp expect actual;;
>> -                       esac &&
>> -                       rm -f "$actual" actual expect
>
> Was this line removed by accident? It doesn't seem related to the
> described change. Shouldn't this line be left after...
>
>> +                       test_cmp expect actual
>
> ...this one?

Yes, it should be in 2/2 where this gets turned into a
test_when_finished "rm [...]", sorry.