From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 30 Aug 2021 14:10:02 GMT
Subject: Re: [PATCH v3 20/25] refs: RFC: Reftable support for git-core
Message-ID: <87ilznxbt0.fsf@evledraar.gmail.com>
In-Reply-To: <CAFQ2z_OTdXSvPcjPRi8fx6F_yjwiL3vRpPtnEOTyaeBxMB2wHQ@mail.gmail.com>


On Mon, Aug 30 2021, Han-Wen Nienhuys wrote:

> On Mon, Aug 23, 2021 at 12:12 PM Ævar Arnfjörð Bjarmason
> [ omitting addressed points]
>> > +initialize ()  {
>> > +     rm -rf .git &&
>>
>> Should instead set up a test_when_finished "rm -rf .git" ?
>
> No. The test framework sets up a scratch repo, but the scratch repo
> doesn't use reftable, so it interferes with the tests.

Perhaps "TEST_NO_CREATE_REPO=1" at the top of the test is more
straightforward in this case?