From: Collin Funk <collin.funk1@gmail.com>
Date: Thu, 12 Jun 2025 03:31:36 GMT
Subject: Re: [PATCH] config.mak.uname: update settings for FreeBSD
Message-ID: <87ikl1eiuf.fsf@gmail.com>
In-Reply-To: <aEpF3ZjNwkR8FssX@humpty.home.comstyle.com>

Hi Brad,

Brad Smith <brad@comstyle.com> writes:

> FreeBSD 6.0 has memmem().
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
>  config.mak.uname | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index b1c5c4d5e8..da592eeaa0 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -302,16 +302,10 @@ ifeq ($(uname_S),FreeBSD)
>          ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)
>  		OLD_ICONV = YesPlease
>          endif
> -	NO_MEMMEM = YesPlease

I don't have a FreeBSD machine that old to test it. But Gnulib's
documentation says it was added in FreeBSD 5.2.1 [1].

Reviewed-by: Collin Funk <collin.funk1@gmail.com>

>  	BASIC_CFLAGS += -I/usr/local/include
>  	BASIC_LDFLAGS += -L/usr/local/lib
>  	DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
>  	USE_ST_TIMESPEC = YesPlease
> -        ifeq ($(shell expr "$(uname_R)" : '4\.'),2)
> -		PTHREAD_LIBS = -pthread
> -		NO_UINTMAX_T = YesPlease
> -		NO_STRTOUMAX = YesPlease
> -        endif
>  	PYTHON_PATH = /usr/local/bin/python
>  	PERL_PATH = /usr/local/bin/perl
>  	HAVE_PATHS_H = YesPlease

Curious about this change though. Are you basing it off a FreeBSD system
you have? Or do we not care about that old version anymore? For
reference, FreeBSD 4.2 was released in 2000.

Collin

[1] https://www.gnu.org/software/gnulib/manual/html_node/memmem.html
[2] https://www.freebsd.org/releases/4.2R/announce/