From: Jim Meyering Date: Sat, 08 Dec 2007 15:48:05 GMT Subject: [PATCH] Fix off-by-one error: don't read the byte before a malloc'd buffer. Message-ID: <87hcitgpca.fsf@rho.meyering.net> * config.c (store_write_pair): Don't read value[-1]. Signed-off-by: Jim Meyering --- config.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/config.c b/config.c index ed96213..6031b38 100644 --- a/config.c +++ b/config.c @@ -652,7 +652,7 @@ static int store_write_pair(int fd, const char* key, const char* value) for (i = 0; value[i]; i++) if (value[i] == ';' || value[i] == '#') quote = 1; - if (value[i-1] == ' ') + if (i && value[i-1] == ' ') quote = 1; if (write_in_full(fd, "\t", 1) != 1 || -- 1.5.3.7.1116.gae2a9