From: Pat Thoyts <patthoyts@users.sourceforge.net>
Date: Mon, 17 Sep 2012 10:47:01 GMT
Subject: Re: [PATCH] git-gui: Fix semi-working shortcuts for unstage and revert
Message-ID: <87haqxj596.fsf@fox.patthoyts.tk>
In-Reply-To: <1347665801-22634-1-git-send-email-vi0oss@gmail.com>

vi0oss@gmail.com writes:

>From: Vitaly _Vi Shukela <vi0oss@gmail.com>
>
>Make Ctrl+U for unstaging and Ctrl+J for reverting selection behave
>more like Ctrl+T for adding.
>
>They were working only when one area was focused (diff or commit message),
>now they should work everywhere.
>
>Signed-off-by: Vitaly _Vi Shukela <vi0oss@gmail.com>
>---
>Sending the patch the third time (haven't got any replies to previous two attempts).
>
> git-gui/git-gui.sh |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
>diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
>index ba4e5c1..6618016 100755
>--- a/git-gui/git-gui.sh
>+++ b/git-gui/git-gui.sh
>@@ -3710,6 +3710,8 @@ bind $ui_diff <$M1B-Key-v> {break}
> bind $ui_diff <$M1B-Key-V> {break}
> bind $ui_diff <$M1B-Key-a> {%W tag add sel 0.0 end;break}
> bind $ui_diff <$M1B-Key-A> {%W tag add sel 0.0 end;break}
>+bind $ui_diff <$M1B-Key-j> {do_revert_selection;break}
>+bind $ui_diff <$M1B-Key-J> {do_revert_selection;break}
> bind $ui_diff <Key-Up>     {catch {%W yview scroll -1 units};break}
> bind $ui_diff <Key-Down>   {catch {%W yview scroll  1 units};break}
> bind $ui_diff <Key-Left>   {catch {%W xview scroll -1 units};break}
>@@ -3742,6 +3744,8 @@ bind .   <$M1B-Key-s> do_signoff
> bind .   <$M1B-Key-S> do_signoff
> bind .   <$M1B-Key-t> do_add_selection
> bind .   <$M1B-Key-T> do_add_selection
>+bind .   <$M1B-Key-u> do_unstage_selection
>+bind .   <$M1B-Key-U> do_unstage_selection
> bind .   <$M1B-Key-j> do_revert_selection
> bind .   <$M1B-Key-J> do_revert_selection
> bind .   <$M1B-Key-i> do_add_all

Looks good to me. Applied.

Thank you. 

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD