From: Thomas Rast <tr@thomasrast.ch>
Date: Thu, 18 Jul 2013 11:56:55 GMT
Subject: Re: [PATCH 5/6] blame-options.txt: place each -L option variation on its own line
Message-ID: <87hafs84jc.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <1374096332-7891-6-git-send-email-sunshine@sunshineco.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> Standard practice in Git documentation is for each variation of an
> option (such as: -p / --porcelain) to be placed on its own line in the
> OPTIONS table. The -L option does not follow suit. It cuddles
> "-L <start>,<end>" and "-L :<regex>", separated by a comma. This is
> inconsistent and potentially confusing since the comma separating them
> is typeset the same as the comma in "<start>,<end>". Fix this by placing
> each variation on its own line.

Ok, but why not fix them all in one go?

Edited to remove the false positives:

$ git grep -n '^.*,.*::$' Documentation/*.txt
Documentation/blame-options.txt:12:-L <start>,<end>, -L :<regex>::
Documentation/config.txt:1252:gitcvs.dbuser, gitcvs.dbpass::
Documentation/config.txt:1513:http.lowSpeedLimit, http.lowSpeedTime::
Documentation/git-add.txt:90:-e, \--edit::
Documentation/git-check-attr.txt:22:-a, --all::
Documentation/git-check-ignore.txt:26:-q, --quiet::
Documentation/git-check-ignore.txt:30:-v, --verbose::
Documentation/git-check-ignore.txt:42:-n, --non-matching::
Documentation/git-log.txt:65:-L <start>,<end>:<file>, -L :<regex>:<file>::
Documentation/git-log.txt:156:git log -L '/int main/',/^}/:main.c::
Documentation/git-p4.txt:171:--verbose, -v::
Documentation/git-p4.txt:282:--dry-run, -n::

-- 
Thomas Rast
trast@{inf,student}.ethz.ch