From: Thomas Rast <trast@inf.ethz.ch>
Date: Wed, 07 Aug 2013 09:48:20 GMT
Subject: Re: [PATCH] die_with_status: use "printf '%s\n'", not "echo"
Message-ID: <87haf1vnkr.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <vpqy58dj1ly.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Thomas Rast <trast@inf.ethz.ch> writes:
>
>>> +	grep -v "	" error
>>
>> Umm, doesn't that only test that _some_ line in the error does not
>> contain a tab?
>
> Indeed. It does work as the error message is just a one-liner, but let's
> be robust anyway.

Err, right.  I actually applied the patch and verified that the test
"erroneously" passed without the fix, but that's simply because I use
bash instead of dash.  The error message indeed is only one line, the
rest of the rebase output goes to stdout.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch