From: David Kastrup Date: Sat, 08 Feb 2014 21:34:42 GMT Subject: Re: [PATCH] builtin/blame.c::prepare_lines: fix allocation size of sb->lineno Message-ID: <87ha89b85p.fsf@fencepost.gnu.org> In-Reply-To: <20140208212154.GA4283@sigill.intra.peff.net> Jeff King writes: > However, is there a reason not to use: > > sizeof(*sb->lineno) > > rather than > > sizeof(int) > > to avoid type-mismatch errors entirely (this applies both to this patch, > and to any proposed rewrites using malloc). It deviates from the style of the original code by tried and true Git developers. So feel free to roll your own patch here: it's not like this one has any copyrightable content in it. -- David Kastrup