From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Wed, 28 Jun 2017 21:42:54 GMT
Subject: Re: [PATCH v2 0/3] update sha1dc from PR #36
Message-ID: <87h8yzkcv5.fsf@gmail.com>
In-Reply-To: <xmqqfuelyuuu.fsf@gitster.mtv.corp.google.com>


On Tue, Jun 27 2017, Junio C. Hamano jotted:

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> A v2 addressing comments to the v1, tbdiff below. Just fixes the
>> subject line on 1/3 & gets rid of the redundant _BIG_ENDIAN detection
>> for Solaris, we can just use __sparc (and indeed we did before this).
>
> Thanks.  Let's have this tested by minority platform folks to help
> the upstream digest your pull request.  The change since the last
> round makes perfect sense to me.

Just a brief update. This has been found not to work on some BSDs (with
older GCC), but there's a patch being discussed at
https://github.com/cr-marcstevens/sha1collisiondetection/pull/34

The discussion is sorted out, just waiting on n-soda to submit a patch
(or to tell me he'd like me to), then the known issues will be fixed &
it should be merged quickly, then I'll submit a v3.