From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 21 Sep 2021 12:04:12 GMT
Subject: Re: [PATCH 4/5] grep: mark "haystack" buffers as const
Message-ID: <87h7ee9lsf.fsf@evledraar.gmail.com>
In-Reply-To: <YUlWXRYv1KtZrxZ6@coredump.intra.peff.net>


On Mon, Sep 20 2021, Jeff King wrote:

> -static int patmatch(struct grep_pat *p, char *line, char *eol,
> +static int patmatch(struct grep_pat *p,
> +		    const char *line, const char *eol,
>  		    regmatch_t *match, int eflags)

nit; not worth a re-roll, over-line-wrapping here? You usually stay at
column 79. In this case both line and eol would fit on the patmatch()
lin, which is being changed anyway...