From: Thomas Rast <trast@student.ethz.ch>
Date: Thu, 28 Feb 2013 19:32:55 GMT
Subject: Re: [PATCH v8 4/5] Implement line-history search (git log -L)
Message-ID: <87fw0g6xp4.fsf@pctrast.inf.ethz.ch>
In-Reply-To: <7vbob4iaxh.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

>> +/*
>> + * NEEDSWORK: manually building a diff here is not the Right
>> + * Thing(tm).  log -L should be built into the diff pipeline.
>
> I am not sure about this design, and do not necessarily agree that
> wedging this to the diff pipeline is the right future direction.
>
> I have a feeling that "log -L" should actually be built around
> "blame".  You let blame to hit the first parent to take the blame,
> and then turn around to show a single "diff-tree" between the child
> and the parent with whatever other diff pipeline gizmo the user can
> give you from the command line.  The blame also tells you what the
> "interesting" line range were at the first parent commit you found,
> so you can re-run the same thing with an updated range.

Hrm, now that you mention it, this is actually a brilliant idea.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch