From: Thomas Rast <trast@inf.ethz.ch>
Date: Tue, 18 Jun 2013 08:23:44 GMT
Subject: Re: [PATCH v2 2/6] test-lib: refactor $GIT_SKIP_TESTS matching
Message-ID: <87fvwfddyn.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <51C0064B.8060408@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Am 6/17/2013 11:18, schrieb Thomas Rast:
>> +match_pattern_list () {
>> +	arg="$1"
>> +	shift
>> +	test -z "$*" && return 1
>> +	for pat
>> +	do
>> +		case "$arg" in
>> +		$pat)
>> +			return 0
>> +		esac
>> +	done
>> +	return 1
>> +}
>
> Watch this failing test case:
>
>    GIT_SKIP_TESTS="t950[012]" ./t3006-ls-files-long.sh
>
> 'pat' is too short and too sweet to be used as a shell variable name in a
> library function. ;)

Gah!  Serves me right for not testing test-lib.  Thanks for noticing.

/me goes stand in the corner for a while

-- 
Thomas Rast
trast@{inf,student}.ethz.ch