From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 24 Mar 2018 09:42:13 GMT
Subject: Re: [PATCH v7 06/13] pack-objects: move in_pack out of struct object_entry
Message-ID: <87efk9yfm2.fsf@evledraar.gmail.com>
In-Reply-To: <20180324063353.24722-7-pclouds@gmail.com>


On Sat, Mar 24 2018, Nguyễn Thái Ngọc Duy wrote:

> +	if (pack->in_pack_by_idx) {
> +		if (p->index <= 0)
> +			die("BUG: found_pack should be NULL "
> +					"instead of having non-positive index");
> +			e->in_pack_idx = p->index;
> +	} else

The indentation after the die() here is wrong. GCC complaining about it:
    
    ./pack-objects.h: In function ‘oe_set_in_pack’:
    ./pack-objects.h:203:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       if (p->index <= 0)
       ^~
    ./pack-objects.h:206:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
        e->in_pack_idx = p->index;
        ^